Displaying database last update date. #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 71.59% 71.48% -0.12%
==========================================
Files 8 8
Lines 514 526 +12
==========================================
+ Hits 368 376 +8
- Misses 146 150 +4
Continue to review full report at Codecov.
|
| @@ -68,14 +68,15 @@ def check(key, db, json, full_report, bare, stdin, files, cache, ignore, output, | |||
| ] | |||
| proxy_dictionary = get_proxy_dict(proxyprotocol, proxyhost, proxyport) | |||
| try: | |||
| vulns = safety.check(packages=packages, key=key, db_mirror=db, cached=cache, ignore_ids=ignore, proxy=proxy_dictionary) | |||
| vulns, db_last_update = safety.check(packages=packages, key=key, db_mirror=db, cached=cache, ignore_ids=ignore, proxy=proxy_dictionary) | |||
There was a problem hiding this comment.
I am afraid that this is changing our internal code API for Safety. People might be relying on this call and will get unexpected tuple as result instead of a single value. Is there a way to handle this without a breaking change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow safety users to check safety DB last update date.
The date is obtained from the field
timestampon the safety db metadata ($meta).