Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CVE identifier to Vulnerability class #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add CVE identifier to Vulnerability class #308

wants to merge 1 commit into from

Conversation

jheyens
Copy link

@jheyens jheyens commented Aug 3, 2020

This adds the CVE information to --json output

@jheyens
Add CVE identifier to Vulnerability class
26741b6 
This adds the CVE information to --json output
@jheyens
Copy link
Author

jheyens commented Aug 3, 2020

I don't think the failing macOS check is caused by this PR, but by some AppVeyor issue.

rafaelpivato
rafaelpivato suggested changes Dec 20, 2020
View reviewed changes
Copy link
Contributor

@rafaelpivato rafaelpivato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Can you update from master and add a test for cases where there is no CVE for a vulnerabilities?

The greatest majority or our vulnerabilities do not come from CVE in fact. Those represent just a small portion of PyUp database.

@rafaelpivato rafaelpivato self-assigned this Dec 20, 2020
@iot-resister
Copy link

iot-resister commented Jan 11, 2021 •
edited

@jheyens I'd love to get this merged. Looking to integrate with gitlab CI.
https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/blob/master/dist/dependency-scanning-report-format.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelpivato rafaelpivato rafaelpivato requested changes

At least 1 approving review is required to merge this pull request.

Assignees

@rafaelpivato rafaelpivato

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jheyens @iot-resister @rafaelpivato