Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for windows and python 3.8 call to add_dll_directory #6742

Merged
merged 1 commit into from Oct 11, 2022
Merged

Fix for windows and python 3.8 call to add_dll_directory #6742

merged 1 commit into from Oct 11, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Oct 11, 2022 •
edited

Fix for windows and python 3.8 call to add_dll_directory
Similar to: pytorch/audio#2747

@atalman atalman requested a review from datumbox October 11, 2022 15:36
datumbox
datumbox approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Do we need to cherrypick this into the release?

Let's wait for the tests to complete before merging.

@atalman
Copy link
Contributor Author

atalman commented Oct 11, 2022

LGTM, thanks! Do we need to cherrypick this into the release?

Let's wait for the tests to complete before merging.

Yes we do need to cherry-pick this. And for sure will wait for this to pass tests

@atalman atalman merged commit 1b5e1b4 into pytorch:main Oct 11, 2022
atalman added a commit to atalman/vision that referenced this pull request Oct 11, 2022
@atalman
Fix for windows and python 3.8 call to add_dll_directory (pytorch#6742)
27822f3
@atalman atalman mentioned this pull request Oct 11, 2022
Open
atalman added a commit that referenced this pull request Oct 11, 2022
@atalman
Fix for windows and python 3.8 call to add_dll_directory (#6742) (#6743)
531a2ea
facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2022
@facebook-github-bot
[fbsync] Fix for windows and python 3.8 call to add_dll_directory (#6742
18b8602 
)

Reviewed By: NicolasHug

Differential Revision: D40427472

fbshipit-source-id: bbcd971213459005e03ea2b0f9e7ff797b7eb228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: ci windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atalman @datumbox @facebook-github-bot