Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.14] Release Tracker #6686

Open
YosuaMichael opened this issue Oct 4, 2022 · 6 comments
Open

[v0.14] Release Tracker #6686

YosuaMichael opened this issue Oct 4, 2022 · 6 comments
Assignees

Comments

@YosuaMichael
Copy link
Contributor

YosuaMichael commented Oct 4, 2022

We cut a release branch for the 0.14 release. (common commit with main is 07ae61b)

This issue is for tracking cherry-picks to the release branch.
The POCs for the TorchVision team are @YosuaMichael and @datumbox

Cherry-Pick Criteria

Phase 1 (until 10/10/22):

Only low-risk changes may be cherry-picked from master:

  1. Fixes to regressions against the most recent minor release (e.g. 0.13 for 0.14 release);
  2. Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
  3. Fixes to new features introduced in the most recent minor release (e.g. 0.13 for 0.14 release)
  4. Test/CI fixes
  5. Documentation improvements
  6. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
  7. Release branch specific changes (e.g. change version identifiers)

Phase 2 (after 10/10/22):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

Changes will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create a PR against the release branch.

    # Find the hash of the commit you want to cherry pick
    # (for example, abcdef12345)
    git log
    
    git fetch origin release/0.14
    git checkout release/0.14
    git cherry-pick abcdef12345
    
    # Submit a PR based against 'release/0.14' either:
    # via the GitHub UI
    git push my-fork
    
    # via the GitHub CLI
    gh pr create --base release/0.14
  3. Make a request below with the following format:

Link to landed master PR (if applicable):
* 

Link to release branch PR:
* 

Criteria Category:
* 
  1. the POC will reply with approved / denied or ask for more information.
  2. If approved, the PR can be merged once the tests pass.

NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

0.14

@pmeier
Copy link
Collaborator

pmeier commented Oct 4, 2022

Link to landed master PR (if applicable): #6694 - MERGED

Link to release branch PR: #6701 - MERGED

Criteria Category: Documentation improvements

@jdsgomes
Copy link
Contributor

jdsgomes commented Oct 4, 2022

Link to landed master PR: #6672 - MERGED

Link to release branch PR: #6703 - MERGED

Criteria Category: Bugfix

@YosuaMichael
Copy link
Contributor Author

YosuaMichael commented Oct 5, 2022

Link to landed master PR: #6700 - MERGED

Link to release branch PR: #6706 - MERGED

Criteria Category: Bugfix

@atalman
Copy link
Contributor

atalman commented Oct 6, 2022

Link to landed master PR (if applicable):

Link to release branch PR:

Criteria Category:

  • CI fix

@atalman merged

@atalman
Copy link
Contributor

atalman commented Oct 11, 2022

Link to landed master PR (if applicable):

Link to release branch PR:

Criteria Category:

  • Critical CI fix

@atalman merged

@YosuaMichael
Copy link
Contributor Author

YosuaMichael commented Oct 27, 2022

Link to landed master PR: #6789 (MERGED)

Link to release branch PR: #6849 (CLOSED)

Criteria: Test/CI Fixes

We cancel cherry-pick this one because it is not critical (dont affect the binary build)

@pmeier pmeier unpinned this issue Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants