-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows python 3.8 required dlls not found #6715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atalman. I don't have too much context around the windows fixes but I trust your judgment on this. LGTM.
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
c079a48
to
e4e3a0d
Compare
Hey @atalman! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
* Fix windows python 3.8 * Update torchvision/extension.py Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> * Update torchvision/extension.py Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
* Fix windows python 3.8 * Update torchvision/extension.py Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> * Update torchvision/extension.py Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Summary: * Fix windows python 3.8 * Update torchvision/extension.py * Update torchvision/extension.py Reviewed By: NicolasHug Differential Revision: D40427461 fbshipit-source-id: 8aeb7eba3dd573b2d700680276cf947d724a1d35 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Fixes following issue:
Same as: pytorch/audio#2735