fix bug in output format for pyav #6672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally: With default parameters: video = read_video("/Users/jdsgomes/repos/video_reader_benchmark/videos/R6llTwEh07w.mp4")
video[0].shapetorch.Size([303, 256, 340, 3])With output_format="TCHW" video = read_video("/Users/jdsgomes/repos/video_reader_benchmark/videos/R6llTwEh07w.mp4", output_format="TCHW")
video[0].shapetorch.Size([303, 3, 256, 340]) |
9 tasks
YosuaMichael
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Thanks @jdsgomes , the PR looks good to me! Lets cherry pick this for v0.14 release.
|
Hey @jdsgomes! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
jdsgomes
added a commit
to jdsgomes/vision
that referenced
this pull request
Oct 4, 2022
* fix bug in output format for pyav * add read from memory with constructor overload * Revert "add read from memory with constructor overload" This reverts commit 14cbbab. * run ufmt
jdsgomes
added a commit
to jdsgomes/vision
that referenced
this pull request
Oct 4, 2022
* fix bug in output format for pyav * add read from memory with constructor overload * Revert "add read from memory with constructor overload" This reverts commit 14cbbab. * run ufmt
This was referenced Oct 4, 2022
YosuaMichael
pushed a commit
that referenced
this pull request
Oct 5, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Summary: * fix bug in output format for pyav * add read from memory with constructor overload * Revert "add read from memory with constructor overload" This reverts commit 14cbbab. * run ufmt Reviewed By: datumbox Differential Revision: D40138748 fbshipit-source-id: f9104cf9c56c3187a22ca6156267d9bf23552f3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug:
when using
video_readerbackend,read_videoignores theoutput_formatparameter