Change new idiom to if/else

pytorch · Oct 4, 2022 · 7c51086 · 7c51086
1 parent 12c8b87
commit 7c51086
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/torchvision/ops/focal_loss.py b/torchvision/ops/focal_loss.py
@@ -34,8 +34,7 @@ def sigmoid_focal_loss(
     # Original implementation from https://github.com/facebookresearch/fvcore/blob/master/fvcore/nn/focal_loss.py
 
     # Check reduction option
-    modes = ["none", "mean", "sum"]
-    if reduction not in modes:
+    if reduction != "none" or reduction != "mean" or reduction != "sum":
         raise ValueError(
             f"Invalid Value for arg 'reduction': '{reduction} \n Supported reduction modes: 'none', 'mean', 'sum'"
         )