Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump black version to 23.1.0 #96578

Closed
wants to merge 4 commits into from
Closed

Bump black version to 23.1.0 #96578

wants to merge 4 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Mar 11, 2023 •
edited by pytorch-bot bot

@BowenBao
Bump black version to 23.1.0
3a25779 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 11, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 11, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96578

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ad34230:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Mar 11, 2023
Closed
Closed
Closed
@BowenBao
Copy link
Collaborator Author

@ezyang not sure who to tag. Is it ok to upgrade black version used in pytorch? There are some bug fixes in newer version regarding #fmt: skip psf/black#3148

ezyang
ezyang approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go go go

@BowenBao BowenBao mentioned this pull request Mar 14, 2023
Closed
@BowenBao
Copy link
Collaborator Author

go go go

thx, enclosing the diffs produced by newer version black in this PR.

@BowenBao
Update on "Bump black version to 23.1.0"
4a413c3 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@ezyang
Copy link
Contributor

ezyang commented Mar 14, 2023

Skimmed, looks fine

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 15, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / cuda11.8-py3.10-gcc7-sm86 / test (inductor_timm_dynamic, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@BowenBao
Update on "Bump black version to 23.1.0"
ad34230 
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BowenBao added a commit to BowenBao/pytorch that referenced this pull request Mar 15, 2023
@BowenBao
Bump black version to 23.1.0
70a72bd 
ghstack-source-id: 791f2ff3284c45b7e124a52c0ad4c5cf6c4f89aa
Pull Request resolved: pytorch#96578

amend black bump
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
@BowenBao @cyyever
Bump black version to 23.1.0 (#96578)
3b8d5a7 
Pull Request resolved: pytorch/pytorch#96578
Approved by: https://github.com/ezyang
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@BowenBao @cyyever
Bump black version to 23.1.0 (#96578)
71ffc60 
Pull Request resolved: pytorch/pytorch#96578
Approved by: https://github.com/ezyang
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/218/head branch June 8, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BowenBao @ezyang @pytorchmergebot @pytorchbot