New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform markers for linux x86_64 only extra_install_requires #91083
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huydhn
added
ciflow/trunk
Trigger trunk jobs on your pull request
ciflow/binaries
Trigger all binary build and upload jobs on the PR
test-config/default
labels
Dec 20, 2022
Please take a look at the failing workflows:
|
ngimel
added
the
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
label
Dec 21, 2022
lawrenceong
reviewed
Jan 9, 2023
"nvidia-cuda-runtime-cu11; platform_system == 'Linux' | " | ||
"nvidia-cudnn-cu11==8.5.0.96; platform_system == 'Linux' | " | ||
"nvidia-cublas-cu11==11.10.3.66; platform_system == 'Linux'", | ||
"nvidia-cuda-runtime-cu11; platform_system == 'Linux'; platform_machine == 'x86_64' | " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this:
Suggested change
"nvidia-cuda-runtime-cu11; platform_system == 'Linux'; platform_machine == 'x86_64' | " | |
"nvidia-cuda-runtime-cu11; platform_system == 'Linux' and platform_machine == 'x86_64' | " |
TimeRainStarSky
force-pushed
the
master
branch
from
January 26, 2023 13:40
bd8d4f8
to
5e9fa0a
Compare
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 31, 2023
…3066) Like #89924 #91083 #85097 added new extra dependencies on nvidia-*. They are linux x86_64 (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on Linux aarch64 systems. This "fixes" the issue by adding the `and platform_machine == 'x86_64'` marker on these dependencies. Pull Request resolved: #93066 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/binaries
Trigger all binary build and upload jobs on the PR
ciflow/trunk
Trigger trunk jobs on your pull request
open source
test-config/default
topic: not user facing
topic category
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #89924
#85097 added new extra dependencies on nvidia-*. They are linux x86_64 (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on Linux aarch64 systems. This "fixes" the issue by adding the
; platform_machine == 'x86_64'
marker on these dependencies.