Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ATen Fallback for BUILD_CAFFE2=0 for ONNX-only ops (#88504) #90104

Merged
merged 5 commits into from Dec 7, 2022
Merged

Fix ATen Fallback for BUILD_CAFFE2=0 for ONNX-only ops (#88504) #90104

merged 5 commits into from Dec 7, 2022

Commits on Dec 6, 2022

  1. Fix ATen Fallback for BUILD_CAFFE2=0 for ONNX-only ops (pytorch#88504) 

    Follow-up for pytorch#87735

Once again, because BUILD_CAFFE2=0 is not tested for ONNX exporter, one scenario slipped through. A use case where the model can be exported without aten fallback when operator_export_type=ONNX_ATEN_FALLBACK and BUILD_CAFFE2=0

A new unit test has been added, but it won't prevent regressions if BUILD_CAFFE2=0 is not executed on CI again

Fixes pytorch#87313

Pull Request resolved: pytorch#88504
Approved by: https://github.com/justinchuby, https://github.com/BowenBao

(cherry picked from commit 5f0783b)
    @thiagocrepaldi @izaitsevfb
    thiagocrepaldi authored and izaitsevfb committed Dec 6, 2022
    Copy the full SHA
    e76cb2f View commit details
    Browse the repository at this point in the history

  2. Update test/onnx/test_pytorch_onnx_no_runtime.py 

    Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com>
    @atalman @thiagocrepaldi
    atalman and thiagocrepaldi committed Dec 6, 2022
    Copy the full SHA
    3f17880 View commit details
    Browse the repository at this point in the history

  3. Update test/onnx/test_pytorch_onnx_no_runtime.py 

    Fix linter
    @atalman
    atalman committed Dec 6, 2022
    Copy the full SHA
    b265e25 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Update test/onnx/test_pytorch_onnx_no_runtime.py 

    Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com>
    @atalman @thiagocrepaldi
    atalman and thiagocrepaldi committed Dec 7, 2022
    Copy the full SHA
    b54a7ab View commit details
    Browse the repository at this point in the history

  2. fix lint warnings

    @izaitsevfb
    izaitsevfb committed Dec 7, 2022
    Copy the full SHA
    3d75c1b View commit details
    Browse the repository at this point in the history