Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform markers for linux only extra_install_requires (#88826) #89924

Merged
merged 1 commit into from Dec 6, 2022

Commits on Dec 6, 2022

  1. Add platform markers for linux only extra_install_requires (pytorch#8…

    …8826)
    
    Fixes pytorch#88049
    
    pytorch#85097 added new extra dependencies on `nvidia-*`. They are linux (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on non-Linux systems. This "fixes" the issue by adding the `; platform_system = 'Linux'` marker on these dependencies, but the main problem of different metadata for different wheels is a [somewhat larger issue](pytorch#88049 (comment)).
    
    pytorch#85097 used `;` as a delimiter for splitting the different deps, but that is the delimiter used in markers, so I changed to split on `|`.
    
    Pull Request resolved: pytorch#88826
    Approved by: https://github.com/neersighted, https://github.com/lalmei, https://github.com/malfet
    JacobHayes authored and atalman committed Dec 6, 2022
    Copy the full SHA
    9336a83 View commit details
    Browse the repository at this point in the history