Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempted fix for nvrtc with lovelace #87611

Closed
wants to merge 1 commit into from
+4 −0
Closed

attempted fix for nvrtc with lovelace #87611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions aten/src/ATen/native/cuda/jit_utils.cpp
View file
Open in desktop
Expand Up @@ -893,6 +893,8 @@ void codegenOutputQuery(
max_dev_version = CUDAVersion(7, 5);
} else if (nvrtc_version == CUDAVersion(11, 0)) { // 11.0 supports 3-8.0
max_dev_version = CUDAVersion(8, 0);
} else if (nvrtc_major == 11 && nvrtc_minor < 8) {
Copy link
Contributor

@malfet malfet Oct 24, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else if (nvrtc_major == 11 && nvrtc_minor < 8) {
} else if (nvrtc_major == 11 && nvrtc_minor <= 8) {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUt versions less than 11.8 support only up to sm_86, so it's like this on purpose, or is my reasoning wrong?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought nvrtc from 11.8 does not support sm_89, as well, does it?

Copy link
Collaborator Author

@ngimel ngimel Oct 24, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, according to #87436 and the docs, cc @eqy and @ptrblck to double check. That PR is of course for nvcc, not nvrtc, but I would expect nvrtc support matrix to be similar.

max_dev_version = CUDAVersion(8, 6);
} else {
// If the driver version is unknown (i.e. newer than this code)
// assume the driver supports this device
Expand Down
2 changes: 2 additions & 0 deletions torch/csrc/jit/codegen/fuser/cuda/fused_kernel.cpp
View file
Open in desktop
Expand Up @@ -64,6 +64,8 @@ void codegenOutputQuery(
max_dev_version = CudaVersion(7, 5);
} else if (nvrtc_version == CudaVersion(11, 0)) { // 11.0 supports 3-8.0
max_dev_version = CudaVersion(8, 0);
} else if (nvrtc_version.first == 11 && nvrtc_version.second < 8) {
max_dev_version = CudaVersion(8, 6);
} else {
// If the driver version is unknown (i.e. newer than this code)
// assume the driver supports this device
Expand Down