Assert if padding mask type is unexpected (#87106) #87384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#87106 Pull Request resolved: pytorch#86353 Fix the issue described in pytorch#86120 Test Plan: buck test mode/opt caffe2/test:test_transformers -- test_train_with_long_type_pad Reviewed By: malfet Differential Revision: D40129968 fbshipit-source-id: d7530d8c4548b9d3a3ef8b9740c93bee000ed809
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87384
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 Failures, 1 PendingAs of commit ce322ca: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@malfet Could you please review this PR |
malfet
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #87106
Fix the issue described in
#86120
Test Plan: buck test mode/opt caffe2/test:test_transformers -- test_train_with_long_type_pad
Reviewed By: malfet
Differential Revision: D40129968
fbshipit-source-id: d7530d8c4548b9d3a3ef8b9740c93bee000ed809
Fixes #ISSUE_NUMBER