Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable AVX512 CPU dispatch by default #80253

Closed
wants to merge 2 commits into from
Closed

Disable AVX512 CPU dispatch by default #80253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34ef508
Disable AVX512 CPU dispatch by default
malfet Jun 24, 2022
419899e
Update trunk workflows to test AVX512 dispatch
malfet Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/trunk.yml
View file
Open in desktop
Expand Up @@ -62,7 +62,7 @@ jobs:
{ config: "default", shard: 1, num_shards: 2, runner: "linux.4xlarge.nvidia.gpu" },
{ config: "default", shard: 2, num_shards: 2, runner: "linux.4xlarge.nvidia.gpu" },
{ config: "slow", shard: 1, num_shards: 1, runner: "linux.4xlarge.nvidia.gpu" },
{ config: "nogpu_NO_AVX", shard: 1, num_shards: 1, runner: "linux.2xlarge" },
{ config: "nogpu_AVX512", shard: 1, num_shards: 1, runner: "linux.2xlarge" },
{ config: "nogpu_NO_AVX2", shard: 1, num_shards: 1, runner: "linux.2xlarge" },
{ config: "jit_legacy", shard: 1, num_shards: 1, runner: "linux.4xlarge.nvidia.gpu" },
{ config: "distributed", shard: 1, num_shards: 2, runner: "linux.8xlarge.nvidia.gpu" },
Expand Down
8 changes: 2 additions & 6 deletions .jenkins/pytorch/test.sh
View file
Open in desktop
Expand Up @@ -149,13 +149,9 @@ if [[ "$BUILD_ENVIRONMENT" == *asan* ]]; then
(cd test && ! get_exit_code python -c "import torch; torch._C._crash_if_aten_asan(3)")
fi

if [[ $TEST_CONFIG == 'nogpu_NO_AVX' ]]; then
if [[ $TEST_CONFIG == 'nogpu_NO_AVX2' ]]; then
export ATEN_CPU_CAPABILITY=default
elif [[ $TEST_CONFIG == 'nogpu_NO_AVX2' ]]; then
export ATEN_CPU_CAPABILITY=default

# TODO: this condition is never (we have no NO_AVX512 config), need to fix this.
elif [[ $TEST_CONFIG == 'nogpu_NO_AVX512' ]]; then
elif [[ $TEST_CONFIG == 'nogpu_AVX512' ]]; then
export ATEN_CPU_CAPABILITY=avx2
fi

Expand Down
4 changes: 3 additions & 1 deletion aten/src/ATen/native/DispatchStub.cpp
View file
Open in desktop
Expand Up @@ -39,7 +39,9 @@ static CPUCapability compute_cpu_capability() {

#if !defined(__powerpc__) && !defined(__s390x__)
if (cpuinfo_initialize()) {
#ifdef HAVE_AVX512_CPU_DEFINITION
// AVX512 can be slower then AVX2, so lets keep it as opt-in
// see https://github.com/pytorch/pytorch/issues/80252
#if defined(HAVE_AVX512_CPU_DEFINITION) && false
// GCC supports some AVX512 intrinsics such as _mm512_set_epi16 only in
// versions 9 & beyond. So, we want to ensure that only releases built with
// supported compilers on supported hardware return CPU Capability AVX512,
Expand Down