Expose iterator-local generator to RandomSampler instance #65857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1eb111c (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Make sure the iter-local generator is attached to Sampler. Then, the state of iter-local generator is able to be serialized and resumed. Differential Revision: [D31288686](https://our.internmc.facebook.com/intern/diff/D31288686) [ghstack-poisoned]
ejguan
added a commit
that referenced
this pull request
Sep 29, 2021
ghstack-source-id: f1edb9c1c28ffb31c1f185f9f0d9da505b604f05 Pull Request resolved: #65857
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Make sure the iter-local generator is attached to Sampler. Then, the state of iter-local generator is able to be serialized and resumed.
Differential Revision: D31288686