Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert generator in Sampler back to lazy construction #63646

Closed
wants to merge 8 commits into from
Closed

Convert generator in Sampler back to lazy construction #63646

wants to merge 8 commits into from

Commits on Aug 20, 2021

  1. Convert Sampler back to lazily construction 

    [ghstack-poisoned]
    @ejguan
    ejguan committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    8b4ddf7 View commit details
    Browse the repository at this point in the history

  2. Update on "Convert Sampler back to lazily construction" 

    Fixes #63609




[ghstack-poisoned]
    @ejguan
    ejguan committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    468acb4 View commit details
    Browse the repository at this point in the history

  3. Update on "Convert generator in Sampler back to lazy construction" 

    Fixes #63609


Differential Revision: [D30451774](https://our.internmc.facebook.com/intern/diff/D30451774)

[ghstack-poisoned]
    @ejguan
    ejguan committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    1b1f1e9 View commit details
    Browse the repository at this point in the history

  4. Update on "Convert generator in Sampler back to lazy construction" 

    Fixes #63609


Differential Revision: [D30451774](https://our.internmc.facebook.com/intern/diff/D30451774)

[ghstack-poisoned]
    @ejguan
    ejguan committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    8251153 View commit details
    Browse the repository at this point in the history

  5. Update on "Convert generator in Sampler back to lazy construction" 

    Fixes #63609


Differential Revision: [D30451774](https://our.internmc.facebook.com/intern/diff/D30451774)

[ghstack-poisoned]
    @ejguan
    ejguan committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    4c639d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Update on "Convert generator in Sampler back to lazy construction" 

    Fixes #63609


- Revert #63026 
  - Sampler is expected to be re-seeded if user specify seed before each epoch
  - Can not attach generator to self with `__iter__` because multiple iterators will ruin the use case
- Add tests to prevent the same case for different Samplers



Differential Revision: [D30451774](https://our.internmc.facebook.com/intern/diff/D30451774)

[ghstack-poisoned]
    @ejguan
    ejguan committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    8aee201 View commit details
    Browse the repository at this point in the history

  2. Update on "Convert generator in Sampler back to lazy construction" 

    Fixes #63609


- Revert #63026 
  - Sampler is expected to be re-seeded if user specify seed before each epoch
  - Can not attach generator to self with `__iter__` because multiple iterators will ruin the use case
- Add tests to prevent the same case for different Samplers
- Keep same functionality introduced in #63026 that user can serialize the Sampler.



Differential Revision: [D30451774](https://our.internmc.facebook.com/intern/diff/D30451774)

[ghstack-poisoned]
    @ejguan
    ejguan committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    725eb13 View commit details
    Browse the repository at this point in the history

  3. Update on "Convert generator in Sampler back to lazy construction" 

    Fixes #63609


- Revert #63026 
  - Sampler is expected to be re-seeded if user specify seed before each epoch
  - Can not attach generator to self with `__iter__` because multiple iterators will ruin the use case
- Add tests to prevent the same case for different Samplers


Differential Revision: [D30451774](https://our.internmc.facebook.com/intern/diff/D30451774)

[ghstack-poisoned]
    @ejguan
    ejguan committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    d506308 View commit details
    Browse the repository at this point in the history