Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test_memory_format_nn_BatchNorm2d in inductor #125970

Closed
wants to merge 3 commits into from
Closed

Skip test_memory_format_nn_BatchNorm2d in inductor #125970

wants to merge 3 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented May 10, 2024

Skipping the test in the context of #125967 until the issue is root caused and fixed properly.

@huydhn huydhn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels May 10, 2024
@huydhn huydhn requested a review from clee2000 May 10, 2024 22:21
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 10, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125970

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2a76415 with merge base ee804d2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn
Copy link
Contributor Author

huydhn commented May 11, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@huydhn huydhn added the topic: not user facing topic category label May 11, 2024
@huydhn
Copy link
Contributor Author

huydhn commented May 11, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

tinglvv pushed a commit to tinglvv/pytorch that referenced this pull request May 14, 2024
@huydhn @tinglvv
Skip test_memory_format_nn_BatchNorm2d in inductor (pytorch#125970)
47a0d93 
Skipping the test in the context of pytorch#125967 until the issue is root caused and fixed properly.

Pull Request resolved: pytorch#125970
Approved by: https://github.com/clee2000
@huydhn huydhn mentioned this pull request May 14, 2024
Closed
shunting314 added a commit that referenced this pull request May 18, 2024
@shunting314
Revert "Skip test_memory_format_nn_BatchNorm2d in inductor (#125970)"
49830fc 
This reverts commit 0a9c6e9.

[ghstack-poisoned]
shunting314 added a commit that referenced this pull request May 18, 2024
@shunting314
Revert "Skip test_memory_format_nn_BatchNorm2d in inductor (#125970)"
7df8eef 
This reverts commit 0a9c6e9.

ghstack-source-id: 5190acf0d730adb6db15e891a0fa7a776cd9dfc0
Pull Request resolved: #126594
shunting314 added a commit that referenced this pull request May 20, 2024
@shunting314
Revert "Skip test_memory_format_nn_BatchNorm2d in inductor (#125970)"
0d8eb2a 
This reverts commit 0a9c6e9.

ghstack-source-id: b3051bfefe0565869de126d3a7227fc3249fb5a8
Pull Request resolved: #126594
shunting314 added a commit that referenced this pull request May 20, 2024
@shunting314
Update base for Update on "Revert "Skip test_memory_format_nn_BatchNo…
cb03e29 
…rm2d in inductor (#125970)""


This reverts commit 0a9c6e9.


enable the test since it's fixed.

[ghstack-poisoned]
shunting314 added a commit that referenced this pull request May 20, 2024
@shunting314
Update on "Revert "Skip test_memory_format_nn_BatchNorm2d in inductor (…
ac372eb 
…#125970)""


This reverts commit 0a9c6e9.


enable the test since it's fixed.

[ghstack-poisoned]
shunting314 added a commit that referenced this pull request May 21, 2024
@shunting314
Update base for Update on "Revert "Skip test_memory_format_nn_BatchNo…
81123f5 
…rm2d in inductor (#125970)""


This reverts commit 0a9c6e9.


enable the test since it's fixed.

[ghstack-poisoned]
shunting314 added a commit that referenced this pull request May 21, 2024
@shunting314
Update on "Revert "Skip test_memory_format_nn_BatchNorm2d in inductor (…
f530b18 
…#125970)""


This reverts commit 0a9c6e9.


enable the test since it's fixed.

[ghstack-poisoned]
shunting314 added a commit that referenced this pull request May 21, 2024
@shunting314
Revert "Skip test_memory_format_nn_BatchNorm2d in inductor (#125970)"
eeec228 
This reverts commit 0a9c6e9.

ghstack-source-id: 4b69ef15a9eb162f5c41d09a25a7bcceec351419
Pull Request resolved: #126594
pytorchmergebot pushed a commit that referenced this pull request May 22, 2024
@shunting314 @pytorchmergebot
Revert "Skip test_memory_format_nn_BatchNorm2d in inductor (#125970)" (…
ce6e36b 
…#126594)

This reverts commit 0a9c6e9.

enable the test since it's fixed.
Pull Request resolved: #126594
Approved by: https://github.com/huydhn
ghstack dependencies: #126586, #126593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee2000 clee2000 clee2000 approved these changes

Assignees
No one assigned
Labels
ci-td-distributed ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huydhn @pytorchmergebot @clee2000