Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage_ipc] Provides IPC extensions for 3rd devices. #125122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mengpenghui
Copy link

@mengpenghui mengpenghui commented Apr 28, 2024

This PR adds IPC-related interfaces for third-party devices on the backend of storage.
Third-party devices can implement the underlying code for inter-process communication through the hooks mechanism.

the part2 of this PR completes the IPC method registration of the third-party device in _generate_storage_methods_for_privateuse1_backend.

Fixes #124902
cc @ezyang @VitalyFedyunin @fakeYan

Copy link

pytorch-bot bot commented Apr 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125122

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 48db9fd with merge base 94b328e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mengpenghui mengpenghui changed the title [Storage_ipc] Provides IPC extensions for 3rd devices. #124902 [Storage_ipc] Provides IPC extensions for 3rd devices. Apr 28, 2024
@mengpenghui mengpenghui force-pushed the ipc_custom_backend branch 3 times, most recently from 317053a to cbf80f5 Compare April 29, 2024 07:16
@cpuhrsch cpuhrsch added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: PrivateUse1 private use labels Apr 30, 2024
@mengpenghui mengpenghui force-pushed the ipc_custom_backend branch 2 times, most recently from 3fc7dad to d8ca66e Compare May 6, 2024 06:35
@mengpenghui mengpenghui changed the title [Storage_ipc] Provides IPC extensions for 3rd devices. [Storage_ipc] Provides IPC extensions for 3rd devices. (Part 1.) May 6, 2024
@mengpenghui mengpenghui changed the title [Storage_ipc] Provides IPC extensions for 3rd devices. (Part 1.) [Storage_ipc] Provides IPC extensions for 3rd devices. May 6, 2024
@mengpenghui
Copy link
Author

mengpenghui commented May 8, 2024

@albanD Please review it, thank you

@albanD
Copy link
Collaborator

albanD commented May 10, 2024

Thanks for the PR!
I'm not very familiar with the IPC story overall so will take a few days for me to find the time to wrap my head around and give a review. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: PrivateUse1 private use open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IPC features for PrivateUse devices
4 participants