Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hybrid sparse COO tensor conversion to meta tensor #125120

Closed
wants to merge 5 commits into from

Conversation

pearu
Copy link
Collaborator

@pearu pearu commented Apr 28, 2024

Copy link

pytorch-bot bot commented Apr 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125120

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3bb888e with merge base 3d1dd79 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pearu added a commit that referenced this pull request Apr 28, 2024
ghstack-source-id: 5ea2fa5b8ab7516030df143901d2022c80e96d96
Pull Request resolved: #125120
@pearu pearu added module: sparse Related to torch.sparse open source topic: not user facing topic category labels Apr 28, 2024
@pearu pearu added release notes: sparse release notes category ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Apr 28, 2024
As in the title.

Addresses a bug reported in #117907 (comment)




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Apr 28, 2024
ghstack-source-id: 2ce0d6b099107ca5c3d99ab4ef2d617cce0836b0
Pull Request resolved: #125120
@pearu pearu requested review from ezyang and amjames April 28, 2024 20:30
As in the title.

Addresses a bug reported in #117907 (comment)




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Apr 29, 2024
ghstack-source-id: 39a61ae1ed80db902e79e951c58ea4bfd42d1ce8
Pull Request resolved: #125120
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey dokey

As in the title.

Addresses a bug reported in #117907 (comment)




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Apr 29, 2024
ghstack-source-id: 5dc86c8e597bf27e47d46efedcdb086c5c80de93
Pull Request resolved: #125120
As in the title.

Addresses a bug reported in #117907 (comment)




cc alexsamardzic nikitaved cpuhrsch amjames bhosmer jcaip

[ghstack-poisoned]
pearu added a commit that referenced this pull request Apr 29, 2024
ghstack-source-id: 06d87bd0b180ad2429177ef484e9cf5bae432eea
Pull Request resolved: #125120
@ezyang
Copy link
Contributor

ezyang commented Apr 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: sparse Related to torch.sparse open source release notes: sparse release notes category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants