New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UFMT on test_indexing&test_view_ops #125112
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125112
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8158113 with merge base 7478b7f (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This diff doesn't seem right
|
fix this issue, please retrigger CI, thanks :-) @ezyang |
You are still inlining the masking calls, whereas previously the test ran the mask call once and then tested the result
I'm sure it also works to test it this way, but it's the principle of the thing (lints should not change code meaning) |
I'm not sure why this code snippet is inlined, anyway, revert these changes |
clean |
@pytorchbot merge |
This PR needs to be approved by an authorized maintainer before merge. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: docker-builds / docker-build (linux.12xlarge, pytorch-linux-focal-py3.8-clang10) Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -f "spurious failure" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Part of #123062 Pull Request resolved: #125112 Approved by: https://github.com/ezyang
Part of #123062
cc @ezyang