Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: nn.Parameter return type identified as Tensor instead of nn.Parameter #125106

Closed
wants to merge 1 commit into from
Closed

Fix: nn.Parameter return type identified as Tensor instead of nn.Parameter #125106

wants to merge 1 commit into from

Conversation

randolf-scholz
Copy link
Contributor

@randolf-scholz randolf-scholz commented Apr 27, 2024 •
edited by pytorch-bot bot

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 27, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125106

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d31517c with merge base 8246f42 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@randolf-scholz randolf-scholz marked this pull request as ready for review April 28, 2024 09:21
@randolf-scholz
Copy link
Contributor Author

@pytorchbot label "module: typing"

@pytorch-bot pytorch-bot bot added the module: typing Related to mypy type annotations label Apr 28, 2024
@ezyang ezyang changed the title Fix: nn.Parameter return type identified as Tensor instead of nn.Paramter Fix: nn.Parameter return type identified as Tensor instead of nn.Parameter Apr 28, 2024
@ezyang
Copy link
Contributor

ezyang commented Apr 28, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 28, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@randolf-scholz
Copy link
Contributor Author

@ezyang There is no release note label for type hint changes, which one should I use? nn?

@ezyang ezyang added topic: improvements topic category module: python frontend For issues relating to PyTorch's Python frontend labels Apr 29, 2024
@ezyang
Copy link
Contributor

ezyang commented Apr 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@randolf-scholz
Copy link
Contributor Author

@pytorchbot label "release notes: python_frontend"

@pytorch-bot pytorch-bot bot added the release notes: python_frontend release notes category label Apr 29, 2024
albanD
albanD approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't effect runtime, so I'm happy with doing it even if it is only a partial fix!

@ezyang
Copy link
Contributor

ezyang commented Apr 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@randolf-scholz randolf-scholz deleted the fix_nn_parameter_new_type_hints branch April 30, 2024 11:20
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
@randolf-scholz @andoorve
Fix: nn.Parameter return type identified as Tensor instead of `nn…
f0de0ab 
….Parameter` (pytorch#125106)

Fixes pytorch#125105

Pull Request resolved: pytorch#125106
Approved by: https://github.com/ezyang, https://github.com/albanD
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@randolf-scholz @petrex
Fix: nn.Parameter return type identified as Tensor instead of `nn…
738284c 
….Parameter` (#125106)

Fixes #125105

Pull Request resolved: #125106
Approved by: https://github.com/ezyang, https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: python frontend For issues relating to PyTorch's Python frontend module: typing Related to mypy type annotations open source release notes: python_frontend release notes category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typing] nn.Parameter return type identified as Tensor by pyright
5 participants
@randolf-scholz @ezyang @pytorchmergebot @albanD @pytorchbot