New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable clang-tidy coverage on torch/csrc/distributed/c10d/* #125102
Draft
cyyever
wants to merge
10
commits into
pytorch:main
Choose a base branch
from
cyyever:distributed_clang_tidy9
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125102
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit e11082a with merge base a5c93a6 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
oncall: distributed
Add this issue/PR to distributed oncall triage queue
label
Apr 28, 2024
cyyever
force-pushed
the
distributed_clang_tidy9
branch
from
April 28, 2024 01:40
b0febf1
to
e375916
Compare
cyyever
force-pushed
the
distributed_clang_tidy9
branch
from
May 11, 2024 01:16
e375916
to
1a37190
Compare
cyyever
force-pushed
the
distributed_clang_tidy9
branch
from
May 11, 2024 03:35
ac6f63a
to
26b1e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
oncall: distributed
Add this issue/PR to distributed oncall triage queue
open source
topic: not user facing
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k