Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test][Distributed] Make more tests multi-threaded. #125095

Closed
wants to merge 3 commits into from
Closed

[Test][Distributed] Make more tests multi-threaded. #125095

wants to merge 3 commits into from

Conversation

fkouteib
Copy link

@fkouteib fkouteib commented Apr 27, 2024 •
edited by pytorch-bot bot

@fkouteib
[Test][Distributed] Make more tests multi-threaded.
0362967 
This conversion covers all tests under 'test/distributed/_tensor' directory.

Fixes pytorch#108744
@fkouteib
Fix linting errors in my changes.
7ccc902
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 27, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125095

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5694412 with merge base f1d1e32 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Apr 27, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 27, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@cpuhrsch cpuhrsch requested a review from wconstab April 30, 2024 19:46
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 30, 2024
@fkouteib fkouteib marked this pull request as draft April 30, 2024 21:58
@fkouteib fkouteib closed this Apr 30, 2024
@fkouteib
Copy link
Author

I will re-submit a new PR with the proper (and narrowed down) changes. Abandoning this PR.

@fkouteib fkouteib deleted the multi-threaded_tests branch April 30, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch more test cases to use MultithreadTestCase
3 participants
@fkouteib @cpuhrsch @pytorchbot