Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1/2] Remove caffe2 db and distributed from build system #125092

Closed
wants to merge 1 commit into from
Closed

[1/2] Remove caffe2 db and distributed from build system #125092

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Apr 27, 2024 •
edited

This PR tries to decompose #122527 into a smaller one. Caffe2 db, distributed build scripts and some binaries have been removed.
To be noted, this was inspired and is co-dev with @r-barnes.

cc @malfet @seemethere @ezyang @gchanan @albanD

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 27, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125092

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a8a048a with merge base d6052a3 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever requested a review from jeffdaily as a code owner April 27, 2024 01:05
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Apr 27, 2024
@cyyever cyyever marked this pull request as draft April 27, 2024 01:06
@r-barnes
Copy link
Contributor

@cyyever - how's this one going?

@cyyever
Copy link
Collaborator Author

cyyever commented Apr 30, 2024 •
edited

@cyyever - how's this one going?

It's better to delete python #125143 first.

@cyyever cyyever force-pushed the caffe2_db branch 2 times, most recently from 19bc783 to 77219eb Compare May 1, 2024 00:35
@cyyever cyyever changed the title Remove caffe2 db Remove caffe2 db and distributed May 1, 2024
@cyyever cyyever force-pushed the caffe2_db branch 2 times, most recently from e630638 to 0a05dcd Compare May 1, 2024 01:12
@cyyever cyyever requested review from r-barnes and ezyang May 1, 2024 01:19
@cyyever cyyever marked this pull request as ready for review May 1, 2024 01:20
@cyyever
Copy link
Collaborator Author

cyyever commented May 1, 2024

@r-barnes Now I think we can also merge it before the python PR.

@cyyever cyyever added topic: bc breaking topic category topic: bc_breaking module: bc-breaking Related to a BC-breaking change caffe2 skip-pr-sanity-checks module: build Build system issues ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request labels May 1, 2024
malfet
malfet approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted code is tested code

@cyyever
Copy link
Collaborator Author

cyyever commented May 1, 2024

Deleted code is tested code

Do you mean deleted code in torch/binaries or other locations?

@cyyever
Copy link
Collaborator Author

cyyever commented May 1, 2024

@r-barnes Help merge it once you are ready?

@cyyever cyyever removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label May 4, 2024
@cyyever cyyever force-pushed the caffe2_db branch 2 times, most recently from 49990ea to 4d88b14 Compare May 4, 2024 00:45
@cyyever cyyever changed the title Remove caffe2 db and distributed [1/2] Remove caffe2 db and distributed from build system May 4, 2024
@cyyever cyyever requested a review from kit1980 May 4, 2024 00:48
@cyyever
Copy link
Collaborator Author

cyyever commented May 4, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-12-py3-arm64 / test (default, 3, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever mentioned this pull request May 4, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request May 5, 2024
@cyyever @pytorchmergebot
[2/2] Remove Caffe2 db and distributed code (#125533)
8a0529e 
This PR follows #125092 to remove caffe2/db/* and caffe2/distributed/* .

Pull Request resolved: #125533
Approved by: https://github.com/kit1980
@r-barnes
Copy link
Contributor

r-barnes commented May 5, 2024

@cyyever - it would have been nice if you'd waited to merge this one: untangling it is going to be messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@r-barnes r-barnes Awaiting requested review from r-barnes

@ezyang ezyang Awaiting requested review from ezyang

@kit1980 kit1980 Awaiting requested review from kit1980

Assignees
No one assigned
Labels
caffe2 ciflow/trunk Trigger trunk jobs on your pull request Merged module: bc-breaking Related to a BC-breaking change module: build Build system issues open source release notes: releng release notes category skip-pr-sanity-checks topic: bc breaking topic category topic: bc_breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cyyever @r-barnes @pytorchmergebot @malfet @pytorchbot