[dynamo] Allow inlining of hooks for the top module #124501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124501
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 4f25ae5 with merge base 96bdb7a ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
anijain2305
added a commit
that referenced
this pull request
Apr 19, 2024
ghstack-source-id: d0e3ef1e8145ffd5479328c2db1989791e3d47b7 Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 19, 2024
ghstack-source-id: a5f07d2a5afff6e5c87d67c1576dcbf1b797b039 Pull Request resolved: #124501
anijain2305
changed the title
anijain2305
added
the
keep-going
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 19, 2024
ghstack-source-id: 7d547b6a6846f2f3b22d01b0bd83da3d9cbfb1fd Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 19, 2024
ghstack-source-id: 9ab0d414af8944a1e50598c05ceb83527525955a Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 24, 2024
ghstack-source-id: e24a9e901f531670d30d3f35f47abb7efd33417f Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 24, 2024
ghstack-source-id: 09aa3ac995270486bef3d810aa8f82750d97022f Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 24, 2024
ghstack-source-id: 281281ea94dd02078eb103c2b103215b85f3ae7f Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 25, 2024
ghstack-source-id: d930e690791daaff77b06ee0e690fc14abccb48b Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 26, 2024
ghstack-source-id: bdc6ca43a5f9c5f5a2671aac76832b901d29379f Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 26, 2024
ghstack-source-id: d82d92f0617ae74a10be8980c421cb79b38f9138 Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Apr 26, 2024
ghstack-source-id: 567f8dbd8d9b790726b2fb9a246c033d22035a44 Pull Request resolved: #124501
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xmfan
reviewed
May 10, 2024
| if inst.opname == "LOAD_FAST" and inst.argval == "inputs_ref_0" | ||
| ] | ||
| self.assertTrue(len(matches) == 1) | ||
| if call_graph_idxs: |
There was a problem hiding this comment.
this just skips the important parts of the test if call_graph_idxs is empty, but as long as test_inputs_aliasing_bytecode_attr_mutations passes, I think we can fix the test after
Merge failedReason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
anijain2305
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: 51408faf9d8b5f054544107f38316f2ccf1f7a3a Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: 69e775f7e420094bbb45c6599cd9cce319e64231 Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: 0e61e8b7440d155db27b8fbf5599ec3592613066 Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 10, 2024
ghstack-source-id: 32fe9e8e06763c120024277f2a5edc8fb4869c4c Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 11, 2024
ghstack-source-id: 029c5026dbe5985b4f58d165d6ea274b23acbcd0 Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 11, 2024
ghstack-source-id: 4146ca80074d5f02bdd1483e620817a39e1502ea Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 11, 2024
ghstack-source-id: 8577df175bad102628e7b7b16872e81d363e2660 Pull Request resolved: #124501
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 11, 2024
ghstack-source-id: 4146ca80074d5f02bdd1483e620817a39e1502ea Pull Request resolved: #124501
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
May 13, 2024
ghstack-source-id: 11c9f439948f4c8eb0a25932169bdc207e6abce0 Pull Request resolved: #124501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang