Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows constraint to mkl package in wheel #121014

Closed
wants to merge 4 commits into from
Closed

Add windows constraint to mkl package in wheel #121014

wants to merge 4 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Mar 1, 2024 •
edited

Follow up on: #102604
Address this comment: #102604 (comment)

Whl metadata for all wheels published to pypi must match, otherwise poetry install will fail see this comment:
#88049 (comment)

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 1, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 1, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121014

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 6b29017 with merge base ea7149a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/binaries_conda Trigger binary build and upload jobs for conda on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 1, 2024
malfet
malfet approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @atalman for keeping PyThon wheel deps poetry compliant

@malfet
Copy link
Contributor

malfet commented Mar 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 1, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@atalman atalman changed the title Add windows x86_64 constraint to mkl package in wheel Add windows constraint to mkl package in wheel Mar 4, 2024
@atalman
Copy link
Contributor Author

atalman commented Mar 4, 2024

@pytorchmergebot merge -f "All required workflows are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Lourencom pushed a commit to Lourencom/pytorch that referenced this pull request Mar 6, 2024
@atalman @Lourencom
Add windows constraint to mkl package in wheel (pytorch#121014)
c0ce69e 
Follow up on: pytorch#102604
Address this comment: pytorch#102604 (comment)

Whl metadata for all wheels published to pypi must match, otherwise poetry install will fail see this comment:
pytorch#88049 (comment)

Pull Request resolved: pytorch#121014
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/binaries_conda Trigger binary build and upload jobs for conda on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atalman @malfet @pytorchmergebot