Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batching rules matrix exp #117934

Closed
wants to merge 8 commits into from
Closed

Conversation

Xiao215
Copy link

@Xiao215 Xiao215 commented Jan 20, 2024

Fixes #115992

This is a follow up on PR #116377

Added matrix_exp to BatchRulesDecomposition.

cc @zou3519 @Chillee @samdow @kshitij12345 @janeyx99

Copy link

pytorch-bot bot commented Jan 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117934

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 1 Unrelated Failure

As of commit a2d1351 with merge base f1aef2c (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Xiao215
Copy link
Author

Xiao215 commented Jan 21, 2024

Anyone knows why I got an Error: Process completed with exit code 128.?

@Skylion007 Skylion007 added module: functorch Pertaining to torch.func or pytorch/functorch release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch labels Jan 21, 2024
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 22, 2024
@zou3519
Copy link
Contributor

zou3519 commented Jan 26, 2024

Anyone knows why I got an Error: Process completed with exit code 128.?

That one is unrelated, we can ignore it.

@zou3519
Copy link
Contributor

zou3519 commented Jan 26, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased batching-rules-matrix_exp onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout batching-rules-matrix_exp && git pull --rebase)

@zou3519 zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 26, 2024
@zou3519
Copy link
Contributor

zou3519 commented Jan 26, 2024

Please shout in three days if I haven't merged this yet

Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failures look real

Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Mar 26, 2024
@ZelboK
Copy link
Contributor

ZelboK commented Apr 19, 2024

@zou3519

Curious to know why you think this is failling? Locally I get this,

File "/home/ksm/pytorch/test/functorch/test_vmap_registrations.py", line 308, in test_unimplemented_batched_registrations
    assert registration in FuncTorchBatchedDecompositionRegistrations, (
AssertionError: Please check that there is an OpInfo that covers the operator aten::matrix_exp and add a registration in BatchedRulesDecompositions.cpp. If your operator isn't user facing, please add it to the xfail list

which is different from what the pipeline describes.

@github-actions github-actions bot closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request module: functorch Pertaining to torch.func or pytorch/functorch open source release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please implement the batching rule for torch.matrix_exp.
6 participants