[BE] Fix SIM118 `in-dict-keys` #100339

justinchuby · 2023-04-30T15:57:38Z

Stack from ghstack (oldest at bottom):

Use {key} in {dict} instead of {key} in {dict}.keys()

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @anijain2305 @soumith @desertfire

Use {key} in {dict} instead of {key} in {dict}.keys() [ghstack-poisoned]

pytorch-bot · 2023-04-30T15:57:41Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100339

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 2 Unrelated Failures

As of commit 36598f4:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base e779a30:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Use {key} in {dict} instead of {key} in {dict}.keys() ghstack-source-id: d6afa1f8deadc56deb609100f84534802a0f3fc7 Pull Request resolved: #100339

pyproject.toml

Skylion007 · 2023-04-30T16:32:14Z

torch/profiler/_utils.py

@@ -96,7 +96,7 @@ def __init__(self, prof: profile):
        self.profile = prof
        self.metrics: Dict[EventKey, EventMetrics] = {}
        self.compute_self_time()
-        self.event_keys = sorted((e for e in self.metrics.keys()),
+        self.event_keys = sorted((e for e in self.metrics),


Suggested change

self.event_keys = sorted((e for e in self.metrics),

self.event_keys = sorted(self.metrics,

I just opened an issue to add a new flake8 comprehension rule to detect these. :) adamchainz/flake8-comprehensions#503

There probably is one already IIRC. I am not sure if it is enabled in our config

@justinchuby Nah, I enabled almost every flake8-comprehension rule in our config, even the ones I added recently. :)

Use {key} in {dict} instead of {key} in {dict}.keys() cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

Use {key} in {dict} instead of {key} in {dict}.keys() ghstack-source-id: a8b1f7c7e412fd43c17ee60e599df8ca96c21fe4 Pull Request resolved: pytorch#100339 Signed-off-by: Justin Chu <justinchu@microsoft.com>

Use {key} in {dict} instead of {key} in {dict}.keys() cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

Use {key} in {dict} instead of {key} in {dict}.keys() ghstack-source-id: a8b1f7c7e412fd43c17ee60e599df8ca96c21fe4 Pull Request resolved: pytorch#100339 Signed-off-by: Justin Chu <justinchu@microsoft.com>

Use {key} in {dict} instead of {key} in {dict}.keys() cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

janeyx99 · 2023-05-01T14:02:25Z

test/cpp/api/optim_baseline.py

changes in this file LGTM

janeyx99 · 2023-05-01T14:03:28Z

test/test_optim.py

janeyx99 · 2023-05-01T14:05:18Z

torch/optim/swa_utils.py

@@ -269,7 +269,7 @@ def update_bn(loader, model, device=None):

        model(input)

-    for bn_module in momenta.keys():
+    for bn_module in momenta:


Would it be better to use an items() call here since we access the key in the next line?

Skylion007 · 2023-05-01T14:07:23Z

test/distributed/fsdp/test_fsdp_state_dict.py

-                    k
-                    for k in dict(module.named_parameters()).keys()
-                    if LINEAR_SKIP in k
+                    k for k in dict(module.named_parameters()) if LINEAR_SKIP in k


the dict() call here is unnecessary now, just unpack the tuple.

NivekT

Changes under torch/utils/data/datapipes/iterLGTM!

albanD · 2023-05-01T16:54:37Z

Hey!
I think it would be better to split this kind of PRs into smaller chunks (since you're already using ghstack, that shouldn't be a problem).
That will make reviewing a lot easier and also allow you to pinpoint the actual breakage from CI more easily.

This comment applies to most PRs in this stack.

github-actions · 2023-06-30T17:34:04Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[BE] Fix SIM118 in-dict-keys

6e53939

Use {key} in {dict} instead of {key} in {dict}.keys() [ghstack-poisoned]

justinchuby requested review from NivekT, ejguan, a team, BowenBao, abock, mrshenli, zhaojuanmao, rohan-varma, H-Huang, awgu, kwen2501, wanchaol, fegin and kiukchung as code owners April 30, 2023 15:57

justinchuby mentioned this pull request Apr 30, 2023

[BE] Fix all B022 useless-contextlib-suppress #100335

Closed

justinchuby requested review from d4l3k, jerryzh168, HDCharles, albanD, janeyx99, jbschlosser and mikaylagawarecki as code owners April 30, 2023 15:57

justinchuby mentioned this pull request Apr 30, 2023

[BE] Fix SIM105 suppressible-exception #100336

Closed

pytorch-bot bot added the release notes: releng release notes category label Apr 30, 2023

This was referenced Apr 30, 2023

[BE] Fix SIM109 compare-with-tuple #100337

Closed

[BE] Fix SIM110 reimplemented-builtin #100338

Closed

github-actions bot added ciflow/inductor module: dynamo labels Apr 30, 2023

github-actions bot added module: inductor release notes: quantization release notes category labels Apr 30, 2023

justinchuby added a commit that referenced this pull request Apr 30, 2023

[BE] Fix SIM118 in-dict-keys

4b761d4

Use {key} in {dict} instead of {key} in {dict}.keys() ghstack-source-id: d6afa1f8deadc56deb609100f84534802a0f3fc7 Pull Request resolved: #100339

pytorchbot added the open source label Apr 30, 2023

Skylion007 reviewed Apr 30, 2023

View reviewed changes

pyproject.toml Show resolved Hide resolved

Skylion007 reviewed Apr 30, 2023

View reviewed changes

justinchuby added 2 commits April 30, 2023 09:44

Update on "[BE] Fix SIM118 in-dict-keys"

5140b2c

Use {key} in {dict} instead of {key} in {dict}.keys() cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

Update on "[BE] Fix SIM118 in-dict-keys"

2987a64

Use {key} in {dict} instead of {key} in {dict}.keys() cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

This was referenced Apr 30, 2023

Fix B007 unused-loop-control-variable #100341

Closed

Add noqa to exsiting files and enable all bugbear rules #100342

Closed

Update on "[BE] Fix SIM118 in-dict-keys"

1fa6a39

Use {key} in {dict} instead of {key} in {dict}.keys() cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

Skylion007 added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Apr 30, 2023

Update on "[BE] Fix SIM118 in-dict-keys"

36598f4

Use {key} in {dict} instead of {key} in {dict}.keys() cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]

janeyx99 reviewed May 1, 2023

View reviewed changes

test/cpp/api/optim_baseline.py

Copy link

Contributor

janeyx99 May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in this file LGTM

janeyx99 reviewed May 1, 2023

View reviewed changes

test/test_optim.py

Copy link

Contributor

janeyx99 May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM

janeyx99 reviewed May 1, 2023

View reviewed changes

Skylion007 reviewed May 1, 2023

View reviewed changes

NivekT reviewed May 1, 2023

View reviewed changes

github-actions bot added the Stale label Jun 30, 2023

justinchuby closed this Jul 20, 2023

facebook-github-bot deleted the gh/justinchuby/41/head branch August 20, 2023 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BE] Fix SIM118 `in-dict-keys` #100339

[BE] Fix SIM118 `in-dict-keys` #100339

justinchuby commented Apr 30, 2023 •

edited by pytorch-bot bot

pytorch-bot bot commented Apr 30, 2023 •

edited

Skylion007 Apr 30, 2023

justinchuby Apr 30, 2023

Skylion007 Apr 30, 2023 •

edited

justinchuby Apr 30, 2023

Skylion007 Apr 30, 2023

janeyx99 May 1, 2023

janeyx99 May 1, 2023

janeyx99 May 1, 2023

Skylion007 May 1, 2023 •

edited

NivekT left a comment

albanD commented May 1, 2023 •

edited

github-actions bot commented Jun 30, 2023

	self.event_keys = sorted((e for e in self.metrics),
	self.event_keys = sorted(self.metrics,

[BE] Fix SIM118 in-dict-keys #100339

[BE] Fix SIM118 in-dict-keys #100339

Conversation

justinchuby commented Apr 30, 2023 • edited by pytorch-bot bot

pytorch-bot bot commented Apr 30, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100339

❌ 12 New Failures, 2 Unrelated Failures

Skylion007 Apr 30, 2023

Choose a reason for hiding this comment

justinchuby Apr 30, 2023

Choose a reason for hiding this comment

Skylion007 Apr 30, 2023 • edited

Choose a reason for hiding this comment

justinchuby Apr 30, 2023

Choose a reason for hiding this comment

Skylion007 Apr 30, 2023

Choose a reason for hiding this comment

janeyx99 May 1, 2023

Choose a reason for hiding this comment

janeyx99 May 1, 2023

Choose a reason for hiding this comment

janeyx99 May 1, 2023

Choose a reason for hiding this comment

Skylion007 May 1, 2023 • edited

Choose a reason for hiding this comment

NivekT left a comment

Choose a reason for hiding this comment

albanD commented May 1, 2023 • edited

github-actions bot commented Jun 30, 2023

[BE] Fix SIM118 `in-dict-keys` #100339

[BE] Fix SIM118 `in-dict-keys` #100339

justinchuby commented Apr 30, 2023 •

edited by pytorch-bot bot

pytorch-bot bot commented Apr 30, 2023 •

edited

Skylion007 Apr 30, 2023 •

edited

Skylion007 May 1, 2023 •

edited

albanD commented May 1, 2023 •

edited