Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AVX512 CPU dispatch by default #80253

Closed
wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 24, 2022

As it can be slower, see #80252
Update trunk test matrix to test AVX512 config in nogpu_AVX512 flavor.
Kill nogpu_noAVX as AVX support were replaced with AVX512 when #61903 were landed

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2022

🔗 Helpful links

❌ 1 New Failures

As of commit 419899e (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-focal-py3.7-gcc7 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-27T05:30:09.4877508Z The PR is introduc...m to confirm whether this change is wanted or not.
2022-06-27T05:30:09.4862116Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> int _0
2022-06-27T05:30:09.4863743Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> __torch__.torch.classes.profiling.SourceRef _0
2022-06-27T05:30:09.4865877Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0
2022-06-27T05:30:09.4867171Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-06-27T05:30:09.4868673Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-06-27T05:30:09.4870114Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-06-27T05:30:09.4872226Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> __torch__.torch.classes.profiling.SourceStats[] _0
2022-06-27T05:30:09.4873707Z processing existing schema:  __init__(__torch__.torch.classes.c10d.ProcessGroup _0, int _1, int _2) -> NoneType _0
2022-06-27T05:30:09.4875098Z processing existing schema:  __init__(__torch__.torch.classes.c10d.Work _0) -> NoneType _0
2022-06-27T05:30:09.4877046Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> NoneType _0
2022-06-27T05:30:09.4877508Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-06-27T05:30:09.4877527Z 
2022-06-27T05:30:09.4877831Z Broken ops: [
2022-06-27T05:30:09.4878685Z 	c10d::broadcast(__torch__.torch.classes.c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3, int _4) -> __torch__.torch.classes.c10d.Work _0
2022-06-27T05:30:09.4878758Z ]
2022-06-27T05:30:09.6014046Z ##[error]Process completed with exit code 1.
2022-06-27T05:30:09.6041099Z Prepare all required actions
2022-06-27T05:30:09.6041209Z Getting action download info
2022-06-27T05:30:09.7687896Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-06-27T05:30:09.7688101Z with:
2022-06-27T05:30:09.7688404Z   github-token: ***

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet requested a review from a team as a code owner June 27, 2022 04:57
@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 27, 2022
@malfet
Copy link
Contributor Author

malfet commented Jun 27, 2022

@pytorchbot merge -f

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

malfet added a commit that referenced this pull request Jun 27, 2022
As it can be slower, see #80252
Update trunk test matrix to test AVX512 config in `nogpu_AVX512` flavor.
Kill `nogpu_noAVX` as AVX support were replaced with AVX512 when #61903 were landed
Pull Request resolved: #80253
Approved by: https://github.com/ngimel

(cherry picked from commit 1481353)
atalman pushed a commit that referenced this pull request Jun 27, 2022
As it can be slower, see #80252
Update trunk test matrix to test AVX512 config in `nogpu_AVX512` flavor.
Kill `nogpu_noAVX` as AVX support were replaced with AVX512 when #61903 were landed
Pull Request resolved: #80253
Approved by: https://github.com/ngimel

(cherry picked from commit 1481353)
facebook-github-bot pushed a commit that referenced this pull request Jun 27, 2022
Summary:
As it can be slower, see #80252
Update trunk test matrix to test AVX512 config in `nogpu_AVX512` flavor.
Kill `nogpu_noAVX` as AVX support were replaced with AVX512 when #61903 were landed

Pull Request resolved: #80253
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/14813536a7120f1104be2270be341b7a383415c5

Reviewed By: atalman

Differential Revision: D37455851

Pulled By: malfet

fbshipit-source-id: e0942709cd026a4fba35a3cbd1f41fe6b2f33bbd
@malfet malfet deleted the malfet/disable-avx512-dispatch-by-default branch July 17, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants