Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for all_gather object #3047

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Added support for all_gather object #3047

merged 6 commits into from
Aug 31, 2023

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Aug 29, 2023 •
edited

Description:

  • Added support for all_gather object

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: distributed Distributed module label Aug 29, 2023
@vfdev-5 vfdev-5 marked this pull request as ready for review August 29, 2023 08:43
@vfdev-5 vfdev-5 force-pushed the extend-idist-all-gather-objects branch from 053ff42 to 5d9ceb0 Compare August 29, 2023 09:45
sadra-barikbin
sadra-barikbin reviewed Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@sadra-barikbin sadra-barikbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 , I put a few comments. 🙏

ignite/distributed/comp_models/base.py Show resolved Hide resolved
ignite/distributed/comp_models/horovod.py Show resolved Hide resolved
ignite/distributed/comp_models/native.py Outdated Show resolved Hide resolved
ignite/distributed/comp_models/native.py Outdated Show resolved Hide resolved
ignite/distributed/comp_models/native.py Outdated Show resolved Hide resolved
tests/ignite/distributed/utils/__init__.py Show resolved Hide resolved
ignite/distributed/comp_models/base.py Show resolved Hide resolved
@vfdev-5 vfdev-5 merged commit 34a707e into master Aug 31, 2023
33 of 39 checks passed
@vfdev-5 vfdev-5 deleted the extend-idist-all-gather-objects branch August 31, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadra-barikbin sadra-barikbin Awaiting requested review from sadra-barikbin

Assignees
No one assigned
Labels
module: distributed Distributed module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vfdev-5 @sadra-barikbin