Fix buck2 targets command for non-ocamlrep users of the fbcode shim #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3563
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 256639e with merge base 99ec946 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57006939 |
bigfootjon
added a commit
to facebook/ocamlrep
that referenced
this pull request
May 9, 2024
Summary: X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 This needs more work, but this is a good start X-link: facebook/folly#2185 Pulled By: bigfootjon Pull Request resolved: #79 bigfootjon Differential Revision: D57006939
bigfootjon
added a commit
to facebook/folly
that referenced
this pull request
May 9, 2024
Summary: X-link: pytorch/executorch#3563 Pull Request resolved: #2185 This needs more work, but this is a good start X-link: #2185 Pulled By: bigfootjon X-link: facebook/ocamlrep#79 bigfootjon Differential Revision: D57006939
bigfootjon
added a commit
to facebook/folly
that referenced
this pull request
May 15, 2024
Summary: X-link: pytorch/executorch#3563 Pull Request resolved: #2185 This needs more work, but this is a good start X-link: #2185 Pulled By: bigfootjon X-link: facebook/ocamlrep#79 bigfootjon Differential Revision: D57006939
facebook-github-bot
force-pushed
the
export-D57006939
branch
from
155d98f
to
0c490b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57006939 |
…3563) Summary: X-link: facebook/ocamlrep#79 X-link: facebook/folly#2185 Test Plan: CI on the ocamlrep PR passes Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon
bigfootjon
added a commit
to facebook/ocamlrep
that referenced
this pull request
May 15, 2024
) Summary: X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 Test Plan: CI on the ocamlrep PR passes Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon
bigfootjon
force-pushed
the
export-D57006939
branch
from
0c490b2
to
256639e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57006939 |
bigfootjon
changed the title
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
May 15, 2024
Summary: X-link: facebook/ocamlrep#79 X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon fbshipit-source-id: bd70508ee634e8089b41f19cbfd471a6a7b9901d
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
May 15, 2024
Summary: X-link: facebook/ocamlrep#79 X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon fbshipit-source-id: bd70508ee634e8089b41f19cbfd471a6a7b9901d
|
@bigfootjon merged this pull request in 4b37444. |
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
May 15, 2024
) Summary: Pull Request resolved: #79 X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 Test Plan: CI on the ocamlrep PR passes Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon fbshipit-source-id: bd70508ee634e8089b41f19cbfd471a6a7b9901d
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
May 15, 2024
Summary: X-link: facebook/ocamlrep#79 X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon fbshipit-source-id: bd70508ee634e8089b41f19cbfd471a6a7b9901d
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
May 15, 2024
Summary: X-link: facebook/ocamlrep#79 X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon fbshipit-source-id: bd70508ee634e8089b41f19cbfd471a6a7b9901d
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
May 15, 2024
Summary: X-link: facebook/ocamlrep#79 X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon fbshipit-source-id: bd70508ee634e8089b41f19cbfd471a6a7b9901d
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
May 15, 2024
Summary: X-link: facebook/ocamlrep#79 X-link: pytorch/executorch#3563 X-link: facebook/folly#2185 Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon fbshipit-source-id: bd70508ee634e8089b41f19cbfd471a6a7b9901d
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
May 15, 2024
…2185) Summary: X-link: facebook/ocamlrep#79 X-link: pytorch/executorch#3563 Pull Request resolved: #2185 Test Plan: CI on the ocamlrep PR passes Reviewed By: shayne-fletcher Differential Revision: D57006939 Pulled By: bigfootjon fbshipit-source-id: bd70508ee634e8089b41f19cbfd471a6a7b9901d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/folly#2185
This needs more work, but this is a good start
X-link: facebook/folly#2185
Pulled By:
bigfootjon
X-link: facebook/ocamlrep#79
bigfootjon
Differential Revision: D57006939