Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update NCCL to v2.21.5 #1780

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Update NCCL to v2.21.5 #1780

wants to merge 3 commits into from
+12 −8

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Apr 8, 2024 •
edited

@bryantbiggs
Copy link
Contributor Author

XRef https://github.com/aws/aws-ofi-nccl/releases/tag/v1.9.0-aws

@Skylion007 Skylion007 mentioned this pull request Apr 13, 2024
Open
@bryantbiggs bryantbiggs mentioned this pull request May 16, 2024
Closed
@nWEIdia
Copy link
Contributor

nWEIdia commented May 16, 2024

Please help integrate #1823's ARM related changes as well, thanks!

@bryantbiggs
Copy link
Contributor Author

@nWEIdia done!

nWEIdia
nWEIdia approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Skylion007
Copy link

Once this is merged, feel free to merge my PR on PyTorch

@bryantbiggs
Copy link
Contributor Author

cc @atalman @malfet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nWEIdia nWEIdia nWEIdia approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bryantbiggs @nWEIdia @Skylion007 @facebook-github-bot