Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update OpenSSL to latest supported version #1739

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bryantbiggs
Copy link
Contributor

OpenSSL 1.1.1 reached EOL 6 months ago https://endoflife.date/openssl

@bryantbiggs
Copy link
Contributor Author

Validated by running the commands used in CI locally:

docker build --target final --build-arg BASE_TARGET=base --build-arg CUDA_VERSION=cpu --build-arg DEVTOOLSET_VERSION=9 -t pytorch/conda-builder:cpu -f conda/Dockerfile .
[+] Building 455.4s (33/33) FINISHED                                                                                                                                                                                                       docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                 0.0s
 => => transferring dockerfile: 3.23kB                                                                                                                                                                                                               0.0s
 => [internal] load metadata for docker.io/library/centos:7                                                                                                                                                                                          0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                    0.0s
 => => transferring context: 2B                                                                                                                                                                                                                      0.0s
 => [base  1/11] FROM docker.io/library/centos:7                                                                                                                                                                                                     0.0s
 => [internal] load build context                                                                                                                                                                                                                    0.0s
 => => transferring context: 260B                                                                                                                                                                                                                    0.0s
 => CACHED [base  2/11] RUN yum update -y                                                                                                                                                                                                            0.0s
 => CACHED [base  3/11] RUN yum install -y wget curl perl util-linux xz bzip2 git patch which unzip                                                                                                                                                  0.0s
 => CACHED [base  4/11] RUN git config --global --add safe.directory '*'                                                                                                                                                                             0.0s
 => CACHED [base  5/11] RUN yum install -y yum-utils centos-release-scl                                                                                                                                                                              0.0s
 => CACHED [base  6/11] RUN yum-config-manager --enable rhel-server-rhscl-7-rpms                                                                                                                                                                     0.0s
 => CACHED [base  7/11] RUN yum install -y devtoolset-9-gcc devtoolset-9-gcc-c++ devtoolset-9-gcc-gfortran devtoolset-9-binutils                                                                                                                     0.0s
 => CACHED [base  8/11] RUN wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm &&     rpm -ivh epel-release-latest-7.noarch.rpm &&     rm -f epel-release-latest-7.noarch.rpm                                                0.0s
 => CACHED [base  9/11] RUN yum install -y cmake3 &&     ln -s /usr/bin/cmake3 /usr/bin/cmake                                                                                                                                                        0.0s
 => CACHED [base 10/11] RUN yum install -y autoconf aclocal automake make sudo                                                                                                                                                                       0.0s
 => CACHED [base 11/11] RUN rm -rf /usr/local/cuda-*                                                                                                                                                                                                 0.0s
 => [openssl 1/3] RUN yum install -y perl-IPC-Cmd                                                                                                                                                                                                   11.0s
 => CACHED [conda 1/2] ADD ./common/install_conda.sh install_conda.sh                                                                                                                                                                                0.0s
 => CACHED [patchelf 1/2] ADD ./common/install_patchelf.sh install_patchelf.sh                                                                                                                                                                       0.0s
 => CACHED [mnist 1/2] ADD ./common/install_mnist.sh install_mnist.sh                                                                                                                                                                                0.0s
 => [mnist 2/2] RUN bash ./install_mnist.sh                                                                                                                                                                                                          4.8s
 => [conda 2/2] RUN bash ./install_conda.sh && rm install_conda.sh                                                                                                                                                                                  44.1s
 => [patchelf 2/2] RUN bash ./install_patchelf.sh && rm install_patchelf.sh && cp $(which patchelf) /patchelf                                                                                                                                       14.5s
 => [openssl 2/3] ADD ./common/install_openssl.sh install_openssl.sh                                                                                                                                                                                 0.1s
 => [openssl 3/3] RUN bash ./install_openssl.sh && rm install_openssl.sh                                                                                                                                                                           184.1s
 => [final 1/8] COPY --from=openssl            /opt/openssl           /opt/openssl                                                                                                                                                                   0.8s 
 => [final 2/8] COPY --from=patchelf           /patchelf              /usr/local/bin/patchelf                                                                                                                                                        0.1s 
 => [final 3/8] COPY --from=conda              /opt/conda             /opt/conda                                                                                                                                                                     6.2s 
 => [final 4/8] ADD  ./java/jni.h /usr/local/include/jni.h                                                                                                                                                                                           0.1s 
 => [final 5/8] COPY --from=mnist  /usr/local/mnist /usr/local/mnist                                                                                                                                                                                 0.2s 
 => [final 6/8] RUN rm -rf /usr/local/cuda                                                                                                                                                                                                           0.3s 
 => [final 7/8] RUN chmod o+rw /usr/local                                                                                                                                                                                                            0.4s 
 => [final 8/8] RUN touch /.condarc &&     chmod o+rw /.condarc &&     chmod -R o+rw /opt/conda                                                                                                                                                    244.9s 
 => exporting to image                                                                                                                                                                                                                               6.6s 
 => => exporting layers                                                                                                                                                                                                                              6.6s 
 => => writing image sha256:d18d5f31d10dc793c2b6f88858fc8f95bd87f709eb5332b73743bd7d6c3970a9                                                                                                                                                         0.0s 
 => => naming to docker.io/pytorch/conda-builder:cpu 

@bryantbiggs
Copy link
Contributor Author

cc @atalman @malfet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants