chore: Update CI workflow versions to use latest checkout (removes deprecation warning) #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…precation warning), and ensure CUDA 12.4 is added consistently across builds
nWEIdia
reviewed
Mar 13, 2024
| @@ -30,10 +30,10 @@ jobs: | |||
| runs-on: linux.2xlarge | |||
| strategy: | |||
| matrix: | |||
| cuda_version: ["124", "121", "118"] | |||
| cuda_version: ["118", "121", "124"] | |||
There was a problem hiding this comment.
What is the benefit of changing the order?
There was a problem hiding this comment.
None! it was just trying to be consistent with increasing versions left-to-right
nWEIdia
reviewed
Mar 13, 2024
| strategy: | ||
| matrix: | ||
| cuda_version: ["121", "118"] | ||
| cuda_version: ["118", "121", "124"] |
There was a problem hiding this comment.
thank you! reverted this change in e5c34ca
nWEIdia
reviewed
Mar 13, 2024
| @@ -37,15 +37,15 @@ jobs: | |||
| runs-on: linux.12xlarge.ephemeral | |||
| strategy: | |||
| matrix: | |||
| cuda_version: ["12.1", "11.8"] | |||
| cuda_version: ["11.8", "12.1", "12.4"] | |||
There was a problem hiding this comment.
thank you! reverted this change in e5c34ca
There was a problem hiding this comment.
Not necessarily needed, but I appreciate it.
nWEIdia
reviewed
Mar 13, 2024
| OS_BASE: "ubuntu18.04" | ||
| CUDA_VERSION: "11.8.0" | ||
| OS: "ubuntu2204" | ||
| OS_BASE: "ubuntu22.04" |
bryantbiggs
changed the title
seemethere
approved these changes
Mar 15, 2024
|
hmmm actions/runner#2906 |
|
@bryantbiggs this PR looks Ok, however there are some errors we want to resolve: https://github.com/pytorch/builder/actions/runs/8970189807/job/24636329217?pr=1734 I see these are related to your comment about: actions/runner#2906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/checkoutv3 uses deprecated nodejs runtime, no-op bump to v4 to remove warning