Fix conda Windows smoke_test #1687
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PYTORCH_BUILD_VERSION can be different then the downloaded artifact
mantaionut
force-pushed
the
fix_nightly_build
branch
from
86ee112
to
9da7585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTORCH_BUILD_VERSION can be different then the downloaded artifact since its using the DATE.
Saw some failures in the windows-binary-conda test pytorch nightly just like https://ossci-raw-job-status.s3.amazonaws.com/log/20797350508.
The issue is caused by using PYTORCH_BUILD_VERSION to install that version however if the build happens the day before it will download for example pytorch-2.3.0.dev20240123-py3.10_cuda11.8_cudnn8_0.tar.bz2 while PYTORCH_BUILD_VERSION will be 2.3.0.dev20240124.
So I removed the PYTORCH_BUILD_VERSION from conda install and instead parse the downloaded artifact name and get its version and use it in conda install
This PR is tested by pytorch/pytorch#118275.