Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aarch64] patch mkldnn acl inner product to accelerate torch.compile() for bert #1631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snadampal
Copy link
Contributor

No description provided.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, patch mkldnn to fix build errors is probably appropriate, but feature work should be done on the appropriate repository.

So lets work with onednn to get this fix landed into their default branch and then probably update a release branch

Also, can you please clarify, if this is a regression from previos release or just a new feature?

@snadampal
Copy link
Contributor Author

snadampal commented Dec 9, 2023

Hi @malfet , this is the PR for oneDNN repo which will be merged for oneDNN 3.4. But the oneDNN3.4 may not be available for PyTorch 2.2 timeline. and this change is mandatory to get torch.compile() performance improvements on aarch64.

@malfet
Copy link
Contributor

malfet commented Dec 9, 2023

@snadampal I understand the sentiment, but:

  • oneDNN PR is not merged yet
  • It's already past the deadline for 2.2 branch cut (and this is a feature work isn't it?)
  • There are no test plan (and CI does not test it at all)
  • Builder is not the right place to apply patches, as it prevents users, who will checkout 2.2 release branch from build package identical to the one being published (all previous patches were to unblock the builds/fix fundamental regressions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants