Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-Only] Use triton pypi package for 2.1.0 release #1533

Merged
merged 2 commits into from Sep 14, 2023

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 13, 2023

This should fix pytorch/pytorch#109221 (comment) in a safe way by just replacing pytorch-triton with triton package for release.

  • torch-2.1.0+cu121.with.pypi.cudnn-cp310-cp310-linux_x86_64.whl should have:
Metadata-Version: 2.1
Name: torch
Version: 2.1.0+cu121.with.pypi.cudnn
...
Requires-Dist: filelock
Requires-Dist: typing-extensions
Requires-Dist: sympy
Requires-Dist: networkx
Requires-Dist: jinja2
Requires-Dist: fsspec
Requires-Dist: nvidia-cuda-nvrtc-cu12 (==12.1.105) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-cuda-runtime-cu12 (==12.1.105) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-cuda-cupti-cu12 (==12.1.105) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-cudnn-cu12 (==8.9.2.26) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-cublas-cu12 (==12.1.3.1) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-cufft-cu12 (==11.0.2.54) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-curand-cu12 (==10.3.2.106) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-cusolver-cu12 (==11.4.5.107) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-cusparse-cu12 (==12.1.0.106) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-nccl-cu12 (==2.18.1) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: nvidia-nvtx-cu12 (==12.1.105) ; platform_system == "Linux" and platform_machine == "x86_64"
Requires-Dist: triton (==2.1.0) ; platform_system == "Linux" and platform_machine == "x86_64"
Provides-Extra: dynamo
Requires-Dist: jinja2 ; extra == 'dynamo'
Provides-Extra: opt-einsum
Requires-Dist: opt-einsum (>=3.3) ; extra == 'opt-einsum'

On the other hand, pytorch-triton-rocm package stay the same for ROCm release.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one better delete this line altogether, as dependency should be trition==2.1.0, but TRITON_VERSION would be 2.1.0+e6216047b8

@huydhn
Copy link
Contributor Author

huydhn commented Sep 13, 2023

I think one better delete this line altogether, as dependency should be triton==2.1.0, but TRITON_VERSION would be 2.1.0+e6216047b8

The TRITON_VERSION is fine and will be the correct 2.1.0 for release. The only concern I have is that I could only find triton=2.1.0 set here pytorch/pytorch#108423 for CUDA 12.1 (https://github.com/pytorch/pytorch/actions/runs/6162117011). So, i'm trying to understand which one set it for 11.8

@huydhn huydhn requested a review from malfet September 13, 2023 21:07
@huydhn
Copy link
Contributor Author

huydhn commented Sep 13, 2023

Note: 12.1 should be fine because it has triton from pytorch/pytorch#108423, but I'm a bit unclear about 11.8, which doesn't set pytorch_extra_install_requirements variable. torch-2.1.0+cu118-cp310-cp310-linux_x86_64.whl looks like this atm:

Metadata-Version: 2.1
Name: torch
Version: 2.1.0+cu118
...
Requires-Dist: filelock
Requires-Dist: typing-extensions
Requires-Dist: sympy
Requires-Dist: networkx
Requires-Dist: jinja2
Requires-Dist: fsspec
Requires-Dist: pytorch-triton (==2.1.0)
Provides-Extra: dynamo
Requires-Dist: jinja2 ; extra == 'dynamo'
Provides-Extra: opt-einsum
Requires-Dist: opt-einsum (>=3.3) ; extra == 'opt-einsum'

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huydhn huydhn merged commit 922b32e into pytorch:release/2.1 Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants