Add manylinux_2_28 image - fix cmake (#1817)

* Manylinux 2_28 fix cmake install * fix
pytorch · May 10, 2024 · ac9a12e · ac9a12e
1 parent b121fe6
commit ac9a12e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/build-manywheel-images.yml b/.github/workflows/build-manywheel-images.yml
@@ -12,6 +12,7 @@ on:
     paths:
       - .github/workflows/build-manywheel-images.yml
       - manywheel/Dockerfile
+      - manywheel/Dockerfile_2_28
       - manywheel/Dockerfile_aarch64
       - manywheel/Dockerfile_cuda_aarch64
       - manywheel/Dockerfile_cxx11-abi
@@ -21,6 +22,7 @@ on:
     paths:
       - .github/workflows/build-manywheel-images.yml
       - manywheel/Dockerfile
+      - manywheel/Dockerfile_2_28
       - manywheel/Dockerfile_aarch64
       - manywheel/Dockerfile_cuda_aarch64
       - manywheel/Dockerfile_cxx11-abi

diff --git a/manywheel/Dockerfile_2_28 b/manywheel/Dockerfile_2_28
@@ -16,7 +16,7 @@ ENV LD_LIBRARY_PATH=/opt/rh/gcc-toolset-${DEVTOOLSET_VERSION}/root/usr/lib64:/op
 # cmake-3.18.4 from pip
 RUN yum install -y python3-pip && \
     python3 -mpip install cmake==3.18.4 && \
-    ln -s /usr/local/bin/cmake /usr/bin/cmake
+    ln -s /usr/local/bin/cmake /usr/bin/cmake3
 
 FROM base as openssl
 # Install openssl (this must precede `build python` step)
@@ -119,10 +119,11 @@ ARG DEVTOOLSET_VERSION=11
 # Ensure the expected devtoolset is used
 ENV PATH=/opt/rh/gcc-toolset-${DEVTOOLSET_VERSION}/root/usr/bin:$PATH
 ENV LD_LIBRARY_PATH=/opt/rh/gcc-toolset-${DEVTOOLSET_VERSION}/root/usr/lib64:/opt/rh/gcc-toolset-${DEVTOOLSET_VERSION}/root/usr/lib:$LD_LIBRARY_PATH
-# cmake
-RUN yum install -y cmake3 && \
-    ln -s /usr/bin/cmake3 /usr/bin/cmake
 
+# cmake-3.18.4 from pip
+RUN yum install -y python3-pip && \
+    python3 -mpip install cmake==3.18.4 && \
+    ln -s /usr/local/bin/cmake /usr/bin/cmake3
 
 FROM cpu_final as cuda_final
 RUN rm -rf /usr/local/cuda-${BASE_CUDA_VERSION}