Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support aten.log1p converter #2823

Merged
merged 2 commits into from May 22, 2024
Merged

feat: support aten.log1p converter #2823

merged 2 commits into from May 22, 2024

Conversation

chohk88
Copy link
Collaborator

@chohk88 chohk88 commented May 9, 2024 •
edited

Description

A converter for the torch.ops.aten.log1p operation (elementwise log(1 + x))

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@chohk88 chohk88 added the component: converters Issues re: Specific op converters label May 9, 2024
@chohk88 chohk88 self-assigned this May 9, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels May 9, 2024
@github-actions github-actions bot requested a review from peri044 May 9, 2024 06:40
zewenli98
zewenli98 approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. The others LGTM. Can you merge it after fixing the functions' names?

py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py Outdated
@@ -1165,6 +1165,57 @@ def aten_ops_log(
)


@dynamo_tensorrt_converter(torch.ops.aten.log2.default)
def log2(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the naming was inconsistent. Can you modify the function name to aten_ops_log2?

py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py Outdated


@dynamo_tensorrt_converter(torch.ops.aten.log10.default)
def log10(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. log10 -> aten_ops_log10

@chohk88 chohk88 merged commit c78fa7c into main May 22, 2024
34 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 approved these changes

@bowang007 bowang007 Awaiting requested review from bowang007

@apbose apbose Awaiting requested review from apbose

@peri044 peri044 Awaiting requested review from peri044

Assignees

@chohk88 chohk88

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chohk88 @zewenli98 @facebook-github-bot