Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TORCHTRT_CHECK to execute_engine #2709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add TORCHTRT_CHECK to execute_engine #2709

wants to merge 1 commit into from

Conversation

gcuendet
Copy link
Contributor

Description

Convert some potential TensorRT errors (returned boolean is false) into proper exceptions, at runtime.

Fixes #2367

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@gcuendet
Add TORCHTRT_CHECK to execute_engine
8f30f2f 
Convert some potential TensorRT errors (returned boolean is false) into
proper exceptions.
@github-actions github-actions bot added component: core Issues re: The core compiler component: runtime labels Mar 25, 2024
@github-actions github-actions bot requested a review from peri044 March 25, 2024 09:37
@narendasan
Copy link
Collaborator

@peri044 can you look at this w.r.t TRT10?

peri044 added a commit that referenced this pull request May 17, 2024
@peri044
chore: cherry pick of #2709
508a29d
@peri044 peri044 mentioned this pull request May 17, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed component: core Issues re: The core compiler component: runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] TensorRT engine exceptions are not raised
3 participants
@gcuendet @narendasan @facebook-github-bot