all_to_one cuda support non-2d inputs #2575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57180617 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IvanKobzarev
pushed a commit
to IvanKobzarev/FBGEMM
that referenced
this pull request
May 9, 2024
Summary: Support non-2d tensors in all_to_one. Sometimes torchrec outputs are empty tensors. This can be solved on python module side guarding empty tensors, but we d better not to have shape dependent logic for PT2 tracing. Differential Revision: D57180617
IvanKobzarev
force-pushed
the
export-D57180617
branch
from
f8f7c44
to
01d742c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57180617 |
IvanKobzarev
pushed a commit
to IvanKobzarev/FBGEMM
that referenced
this pull request
May 9, 2024
Summary: Support non-2d tensors in all_to_one. Sometimes torchrec outputs are empty tensors. This can be solved on python module side guarding empty tensors, but we d better not to have shape dependent logic for PT2 tracing. Differential Revision: D57180617
IvanKobzarev
force-pushed
the
export-D57180617
branch
from
01d742c
to
316aacb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57180617 |
Summary: Support non-2d tensors in all_to_one. Sometimes torchrec outputs are empty tensors. This can be solved on python module side guarding empty tensors, but we d better not to have shape dependent logic for PT2 tracing. Differential Revision: D57180617
IvanKobzarev
force-pushed
the
export-D57180617
branch
from
316aacb
to
2e5438a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57180617 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support non-2d tensors in all_to_one.
Sometimes torchrec outputs are empty tensors.
This can be solved on python module side guarding empty tensors, but we d better not to have shape dependent logic for PT2 tracing.
Differential Revision: D57180617