Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert D56685840: Multisect successfully blamed "D56685840: [fbgemm] Change model transform fp8 linear op to fbgemm quantize ops" for one test failure #2545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jianyuh
Copy link
Member

@jianyuh jianyuh commented Apr 29, 2024

Summary:
This diff reverts D56685840
D56685840: [fbgemm] Change model transform fp8 linear op to fbgemm quantize ops by jianyuh causes the following test failure:

Tests affected:

Here's the Multisect link:
https://www.internalfb.com/multisect/4966282
Here are the tasks that are relevant to this breakage:
T174133180: 10+ tests unhealthy for oncall_model_processing_components_infra

The backout may land if someone accepts it.

If this diff has been generated in error, you can Commandeer and Abandon it.

Reviewed By: jianyuh

Differential Revision: D56714397

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 275dfcb
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/662fed1e5626ce000842d21c
😎 Deploy Preview https://deploy-preview-2545--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…Change model transform fp8 linear op to fbgemm quantize ops" for one test failure

Summary:
This diff reverts D56685840
D56685840: [fbgemm] Change model transform fp8 linear op to fbgemm quantize ops by jianyuh causes the following test failure:

Tests affected:
- [cogwheel:cogwheel_gpu_ait_lowering_latency_regression_test#main](https://www.internalfb.com/intern/test/281475067301657/)

Here's the Multisect link:
https://www.internalfb.com/multisect/4966282
Here are the tasks that are relevant to this breakage:
T174133180: 10+ tests unhealthy for oncall_model_processing_components_infra

The backout may land if someone accepts it.

If this diff has been generated in error, you can Commandeer and Abandon it.

Reviewed By: jianyuh

Differential Revision: D56714397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants