Make CowClipDefinition and CounterBasedRegularizationDefinition hashable #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
csmiler
force-pushed
the
export-D56643198
branch
from
627f69e
to
3c5d004
Compare
Summary: Mutable dataclass fails at https://fburl.com/code/dksx3yjo due to ``` TypeError: unhashable type: 'CowClipDefinition' ``` https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-350x_eb6_64_2560_0311_optim_eps_cowclip-a653e81151?job_attempt=0&version=0&env=PRODUCTION Making these definitions `frozen` fixes the problem. Differential Revision: D56643198
csmiler
force-pushed
the
export-D56643198
branch
from
3c5d004
to
04ef3e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D56643198