Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version requirement in repository README #944

Closed
wants to merge 1 commit into from

Conversation

Bluenix2
Copy link

It seems like the repository README was left unchanged after #881 and #893 - this PR addresses that by updating the README for the whole repository.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Bluenix2

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is actually correct. It's talking about the now-obsolete typing backport, not about typing-extensions.

@AA-Turner
Copy link
Member

That refers to the backport of the typing module (https://pypi.org/project/typing/), which has been removed. There might be value in adding a note about typing_extensions though?

@Bluenix2
Copy link
Author

I could certainly repurpose this pull request for that purpose - I just have two questions about the CLA:

  • Believe it or not my name is not Bluenix, do I need to sign with my real-life name?

  • What about the address, is country enough or do I need to provide street name and number?

If possible I would prefer not to reveal my real-life name and address.

@JelleZijlstra
Copy link
Member

I don't think any of us know a whole lot about the CLA, sorry (or, for example, why we can get away with not having a CLA requirement on typeshed).

@Bluenix2
Copy link
Author

Bluenix2 commented Dec 6, 2021

Shortly after this I finally found an email to contact and got my questions answered, I also signed the CLA.

That said, there is not much of a use for this PR so I'll go ahead and close it.

@Bluenix2 Bluenix2 closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants