Updated conformance test results for mypy 1.10 and pyright 1.1.360. M… #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypy added partial support for TypeAliasType and TypeIs. Pyright fixed a couple of bugs in constructor call evaluation.
| @@ -1,28 +1,20 @@ | |||
| conformant = "Unsupported" | |||
There was a problem hiding this comment.
This can probably be moved to "Partial".
There was a problem hiding this comment.
I considered that, but I think it's a stretch to say that mypy supports this feature. It no longer generates errors, but it also doesn't implement the feature in any real way. I think "Unsupported" better captures the current state.
| @@ -58,5 +58,4 @@ Line 27: Unexpected errors ['aliases_typealiastype.py:27:17 Undefined attribute | |||
| Line 35: Unexpected errors ['aliases_typealiastype.py:35:4 Undefined or invalid type [11]: Annotation `GoodAlias4` is not defined as a type.'] | |||
| Line 37: Unexpected errors ['aliases_typealiastype.py:37:4 Undefined or invalid type [11]: Annotation `GoodAlias5` is not defined as a type.'] | |||
| Line 39: Unexpected errors ['aliases_typealiastype.py:39:4 Invalid type [31]: Expression `$local_aliases_typealiastype$GoodAlias5[(int, str, [int, str], *tuple[(int, str, int)])]` is not a valid type.'] | |||
| Line 49: Unexpected errors ['aliases_typealiastype.py:49:12 Undefined attribute [16]: Module `typing` has no attribute `TypeAliasType`.'] | |||
There was a problem hiding this comment.
Odd that something changed here, since we're still running the same version of Pyre.
There was a problem hiding this comment.
That's because I needed to add a new "E?" to the test to accommodate mypy's reporting of circular dependencies between type alias definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ypy added partial support for TypeAliasType and TypeIs. Pyright fixed a couple of bugs in constructor call evaluation.