Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stubsabot] Bump pywin32 to 305.* #9118

Closed
wants to merge 2 commits into from
Closed

[stubsabot] Bump pywin32 to 305.* #9118

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2022 •
edited

Release: https://pypi.org/pypi/pywin32/305
Homepage: https://github.com/mhammond/pywin32

⚠️ Review this PR manually, as stubtest is skipped in CI for pywin32! ⚠️

@JelleZijlstra JelleZijlstra reopened this Nov 7, 2022
@github-actions

This comment has been minimized.

Sign in to view
@Avasam
Copy link
Sponsor Collaborator

Avasam commented Nov 7, 2022 •
edited

This stub is skipped in stubtest until #8660/#8923, python/mypy#13822 and python/mypy#13871 . It has to be run locally on Windows with a dev mypy.stubtest version (or turn ignore_missing_stub = true with mypy 0.982).

CHANGES.txt: https://github.com/mhammond/pywin32/blob/52628af307f9ce29864bbfd62eb3a02c74fa3272/CHANGES.txt#L17
Code changes since 304: mhammond/pywin32@b304...b305

I can validate the changes later this week if you'd like.

AlexWaygood added a commit that referenced this pull request Nov 8, 2022
@AlexWaygood
stubsabot: warn if stubtest is skipped in CI (for real this time)
2129c0e 
Fixes a bug in #8681. The logic currently is broken; there should have been a warning message in the PR body for #9118, but there wasn't.
@AlexWaygood AlexWaygood mentioned this pull request Nov 8, 2022
Merged
JelleZijlstra pushed a commit that referenced this pull request Nov 8, 2022
@AlexWaygood
stubsabot: warn if stubtest is skipped in CI (for real this time) (#9133
efa1048 
)

Fixes a bug in #8681. The logic currently is broken; there should have been a warning message in the PR body for #9118, but there wasn't.
[stubsabot] Bump pywin32 to 305.*
a49d62b 
Release: https://pypi.org/pypi/pywin32/305
Homepage: https://github.com/mhammond/pywin32

⚠️ Review this PR manually, as stubtest is skipped in CI for pywin32! ⚠️
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor Author

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member

@Avasam are we good to merge this now?

@Avasam
Copy link
Sponsor Collaborator

Avasam commented Nov 10, 2022 •
edited

@Avasam are we good to merge this now?

45 stubtest errors found. So no. Mainly because win32comext.internet.internet no longer makes a call that fails stubtest and new flags (constants) were added. I'm working on a PR.

@AlexWaygood
Copy link
Member

I'm working on a PR.

Amazing, thank you!

@Avasam Avasam mentioned this pull request Nov 10, 2022
Merged
@AlexWaygood AlexWaygood deleted the stubsabot/pywin32 branch November 10, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Avasam @AlexWaygood @JelleZijlstra