New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new functions for Babel 2.11.0 #9091
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks (and welcome to typeshed)! I'm not too familiar with babel, but here's two suggestions from quickly skimming the source code:
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Btw, we have pre-commit.ci's "autofix" feature enabled for this repo. It looks like you didn't tick the "allow maintainers to edit this PR" box when you filed this PR — I don't think there's any way for you to change it now, but if you had ticked that box, some bots would have already automatically fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm aware of the issue and unfortunately I don't have the option to "allow maintainers to edit this PR" since I created the fork in an Organization account. I was having a hard time getting pre-commit to run locally and it turns out the |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Adds new functions added to Babel 2.11.0 in Add support for compact decimal formats python-babel/babel#909
Fixes Support types for
format_compact_decimal
(Babel 2.11.0) #9090