New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mypy to 0.981 #8796
Bump mypy to 0.981 #8796
Changes from all commits
21063ca
f311079
030eecc
6932212
68fd42f
d1b47ce
f4b2d4b
703ee69
5327b43
dc3e0a5
21431a9
b4bee11
92fcb09
8376b8e
24e32d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,6 +41,9 @@ class _EntryPointBase(NamedTuple): | |
|
||
class EntryPoint(_EntryPointBase): | ||
pattern: ClassVar[Pattern[str]] | ||
if sys.version_info >= (3, 11): | ||
def __init__(self, name: str, value: str, group: str) -> None: ... | ||
|
||
Comment on lines
+44
to
+46
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The allowlist entry had a comment saying that it was to do with |
||
def load(self) -> Any: ... # Callable[[], Any] or an importable module | ||
@property | ||
def extras(self) -> list[str]: ... | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,2 @@ | ||
# yaml._yaml is for backwards compatibility so none of it matters anyway | ||
yaml._yaml.CEmitter.__pyx_vtable__ | ||
yaml._yaml.CParser.__pyx_vtable__ | ||
yaml._yaml.__test__ |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,7 +72,7 @@ class HTMLBinaryInputStream(HTMLUnicodeInputStream): | |
def detectEncodingMeta(self): ... | ||
|
||
class EncodingBytes(bytes): | ||
def __new__(cls, value): ... | ||
def __new__(self, value): ... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change isn't strictly related to the mypy bump, but it was a very easy allowlist entry to fix, and it means that we can delete the whole allowlist for |
||
def __init__(self, value) -> None: ... | ||
def __iter__(self): ... | ||
def __next__(self): ... | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,5 +21,4 @@ six.viewkeys | |
six.viewvalues | ||
|
||
# Unclear problems | ||
six.Iterator.__init__ | ||
six.callable |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these new mypy errors are already fixed on mypy master, by python/mypy#13461. Unfortunately, it doesn't look like that PR made it into 0.981 (cc. @hauntsaninja, @ilevkivskyi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jhance if people will complain about this, we will need to CP it and release 0.982.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexWaygood mypy 0.982 was released with the fix for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Molkree thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy was successfully bumped to 0.982 in #8831; the
type ignore
s are gone again 🎉Thanks @ilevkivskyi for the work on the patch release!