Allow List[str] for requests.Session.request(params=)

[sathieu]

From source:

        #: Dictionary of querystring data to attach to each
        #: :class:`Request <Request>`. The dictionary values may be lists for
        #: representing multivalued query parameters.
        self.params = {}

[hauntsaninja]

Thanks, looks good, syntax aside! I also checked that the comment is up to date: https://github.com/psf/requests/blob/2c2138e811487b13020eb331482fb991fd399d4e/requests/models.py#L97

[sathieu]

@hauntsaninja I've fixed the syntax and added the same annotation to the attribute.

[sathieu]

Also from doc:

You can also pass a list of items as a value:

>>> payload = {'key1': 'value1', 'key2': ['value2', 'value3']}

>>> r = requests.get('https://httpbin.org/get', params=payload)
>>> print(r.url)
https://httpbin.org/get?key1=value1&key2=value2&key2=value3

[hauntsaninja]

Thanks! :-)

[Akuli]

I wonder if it still accepts Dict[str, str], as the value type of MutableMapping is invariant.

[hauntsaninja]

Oh that's a good point. We should probably just steal the type from

typeshed/stubs/requests/requests/api.pyi

Line 13 in cb03e90

params: Optional[

[srittau]

Minor nit for future reference: built-in generics are now mostly supported in typeshed (#4820) and should be used over the generics from typing where possible.