Upgrade to isort 5 #4323
Merged
Upgrade to isort 5 #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now also reformats imports not at the top of files.
JelleZijlstra
approved these changes
Jul 9, 2020
| @@ -155,7 +155,7 @@ class Event: | |||
| def wait(self, timeout: Optional[float] = ...) -> bool: ... | |||
|
|
|||
| if sys.version_info >= (3, 8): | |||
| from _thread import _ExceptHookArgs as ExceptHookArgs, ExceptHookArgs as _ExceptHookArgs # don't ask | |||
| from _thread import ExceptHookArgs as _ExceptHookArgs, _ExceptHookArgs as ExceptHookArgs # don't ask | |||
Just using "profile = black" doesn't work in the configuration file for unknown reasons.
|
@rchen152 pytype doesn't like isort's syntax it seems. Could you have a look? |
|
I think isort 5.1 fixes this PyCQA/isort#1280 |
|
@hauntsaninja It works now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now also reformats imports not at the top of files.